Re: [Xen-devel] [PATCH V4 0/8] COLO-Proxy: Make Xen COLO use userspace colo-proxy

[Zhang Chen <zhangchen.fnst@xxxxxxxxxxxxxx>]

On 03/06/2017 10:31 PM, Konrad Rzeszutek Wilk wrote:
> On Mon, Mar 06, 2017 at 10:59:18AM +0800, Zhang Chen wrote:
> > Because of some reason, We no longer support COLO kernel proxy.
> However the #7 talks about kernel colo proxy? Is this description
> out-dated?
In patch 7/8, the comments:

We use kernel colo proxy's way to get the checkpoint event
from qemu colo-compare.

Here, I mean we use same method communicate with qemu colo-compare
like colo kernel proxy do, we both use the socket.

> > V4:
> One usually adds these comments to the patches. That is
> right after the '---' you say:
>
> v4: New patch
>
> (for the new patches)
>
> Or for the older patches (like #7):
>
> v4: Fix typo.
>      Fix 'some bug' (perhaps be specific).
OK, I will add version comments in patches next version.

> >     - Because the origin 3/7 has been merged,
> >       remove it in this series.
> >     - Add new patch "COLO-Proxy: Add colo-compare notify args"
> >       to support qemu side patch:
> >       https://lists.nongnu.org/archive/html/qemu-devel/2017-02/msg07265.html
> >
> >     - Add colo_userspace_proxy macro as a separate patch.
> >     - Add some comments about COLO and fix some typo in patch 2/7.
> >     - Fix some bug and typo in patch 7/7.
> But the subject is 0/8? So it can't be 7/7. Did you mean
> 7/8? or 8/8/?
Sorry, s/"7/7"/"7/8",  s/"2/7"/"2/8".

Thanks
Zhang Chen

> >     - Rebase codes on upstream Xen.
> Thanks!
>
>
> .
--
Thanks
Zhang Chen




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel