Re: [Xen-devel] [PATCH RFC 0/5] Refactor x86 domain builder

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.03.17 at 14:41, <wei.liu2@xxxxxxxxxx> wrote:
> On Fri, Mar 03, 2017 at 04:06:00AM -0700, Jan Beulich wrote:
>> >>> On 03.03.17 at 11:56, <andrew.cooper3@xxxxxxxxxx> wrote:
>> > On 03/03/17 09:41, Wei Liu wrote:
>> > Jan: Would you be happy accepting my CONFIG_{PV,HVM} patch in its silent
>> > form for now?  If so, I will respin it.
>> 
>> I think so, yes.
>> 
>> >> This series is built on top of Roger's PVHv1 removal series.
>> >>
>> >> Wei Liu (5):
>> >>   xen: move round_pg{up,down} to pfn.h
>> >>   xen: include xen/types.h in domain.h
>> >>   x86: split PV dom0 builder to domain_build_pv.c
>> >>   x86: split PVH dom0 builder to domain_build_pv.c
>> >>   x86: clean up header files in domain_build.c
>> > 
>> > I'd argue that these should be named differently.  They are specifically
>> > hwdom_build.c, distinct from general domain building operations.
>> 
>> hwdom_build.c is wrong too - this is strictly Dom0, i.e. it ought
>> to be dom0_build.c.
> 
> Yes, I agree.
> 
> We shall have dom0_build.c, dom0_build_pv.c and dom0_build_pvh.c in v2.

You mean

dom0_build.c
hvm/dom0_build.c
pv/dom0_build.c

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel