Re: [Xen-devel] [PATCH] x86/SVM: correct boot time cpu_data[] handling

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 02/03/17 15:33, Jan Beulich wrote:
>>>> On 02.03.17 at 16:06, <andrew.cooper3@xxxxxxxxxx> wrote:
>> On 02/03/17 13:08, Jan Beulich wrote:
>>> start_svm() already runs after cpu_data[] was set up, so it shouldn't
>>> modify it anymore (at least not directly). Constify the involved
>>> pointers.
>>>
>>> Furthermore LMSLE feature detection was broken by 566ddbe833 ("x86:
>>> Fail CPU bringup cleanly if it cannot initialise HVM"), as Andrew
>>> Cooper has pointed out: c couldn't possibly equal &boot_cpu_data
>>> anymore.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> I was hoping to avoid fixing LMSLE this until I had enough CPUID
>> infrastructure in place to make it migration safe.
>>
>> OTOH, I can't really object to the patch either.
>>
>> Would you mind if we #if 0'd the LMSLE bit for now, to avoid introducing
>> a window where it definitely isn't migration safe?
> I can do this, albeit a little reluctantly. I'd prefer "if ( 0 && ...)"
> though, to keep the code getting seen by the parser.

Fine by me.  (Along with a TODO, which I will eventually get around to
taking back out).

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel