Re: [Xen-devel] [RFC PATCH v1 07/21] ARM: NUMA: Parse memory NUMA information

[Julien Grall <julien.grall@xxxxxxx>]

Hello Vijay,

On 02/03/17 12:25, Vijay Kilari wrote:
> On Mon, Feb 20, 2017 at 11:35 PM, Julien Grall <julien.grall@xxxxxxx> wrote:
> > On 09/02/17 15:56, vijay.kilari@xxxxxxxxx wrote:
[...]

> > Rather than reimplementing the wheel, it might be better to hook the parsing
> > in bootfdt.c. This would avoid an extra parsing of the device-tree,
> > duplicate the code and expose primitive for early DT parsing.
> The process_memory_node() is called only if EFI_BOOT is not enabled. So
> hooking might not work.
This series adds this change (see patch #5) and the code is not set in 
stone.
We should rework the code when it makes sense rather than trying to find 
a more convolute way.
> > Similarly to the CPUs, this code is wrong. You should check the type =
> > "memory".
>  if (!dt_node_type(node, "memory") ) should be fine?
You would have to create an helper for that. But the idea is there.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel