Re: [Xen-devel] [DO NOT APPLY PATCH XTF 0/2] UMIP test case

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Mar 02, 2017 at 09:05:27AM +0000, Andrew Cooper wrote:
> On 02/03/2017 08:42, Wei Liu wrote:
> > I wrote this long time ago before UMIP was merged.
> >
> > Yu, since you asked, I might as well post it for your reference on how to
> > do it with XTF.
> >
> > This series is not yet tested in any way.
> 
> Unfortunately, you execute all of the sensitive instructions in kernel
> mode, where they wouldn't fault even with UMIP active.
> 
> For full testing of a feature like this, the test should include a check
> that the ability to modify CR4.UMIP depends strictly on the visibility
> of the feature, that uses in the kernel still continue to work, even
> when active, and that behaviour returns back to normal after the feature
> has been deactivated.
> 

I'm pretty sure there are bugs. :-)

> The first patch however, is fine to go in.

Feel free to pick it up in your next batch.

> 
> ~Andrew
> 
> (I am also going to pretend I didn't see those macros :) )

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel