Re: [Xen-devel] [PATCH 1/2] xenstore: free resp in do_control_help

[Juergen Gross <jgross@xxxxxxxx>]

On 01/03/17 12:07, Wei Liu wrote:
> Coverity-ID: 1401603
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Juergen Gross <jgross@xxxxxxxx> 
> ---
>  tools/xenstore/xenstored_control.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/xenstore/xenstored_control.c 
> b/tools/xenstore/xenstored_control.c
> index 7c149117b1..d99b7eb7f9 100644
> --- a/tools/xenstore/xenstored_control.c
> +++ b/tools/xenstore/xenstored_control.c
> @@ -171,6 +171,8 @@ static int do_control_help(void *ctx, struct connection 
> *conn,
>       resp[len] = 0;
>  
>       send_reply(conn, XS_CONTROL, resp, len);
> +
> +     talloc_free(resp);

Sorry, no. The context for the allocation is "in" which will be freed
automatically.


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel