Re: [Xen-devel] [PATCH v8 00/24] Enable L2 Cache Allocation Technology & Refactor psr.c

[Roger Pau Monn� <roger.pau@xxxxxxxxxx>]

On Wed, Mar 01, 2017 at 12:54:54PM +0800, Yi Sun wrote:
> On 17-02-28 11:02:42, Roger Pau Monn� wrote:
> > On Wed, Feb 15, 2017 at 04:49:15PM +0800, Yi Sun wrote:
> > > Hi all,
> > > 
> > > We plan to bring a new PSR (Platform Shared Resource) feature called
> > > Intel L2 Cache Allocation Technology (L2 CAT) to Xen.
> > > 
> > > Besides the L2 CAT implementaion, we refactor the psr.c to make it more
> > > flexible to add new features and fulfill the principle, open for extension
> > > but closed for modification. We abstract the general operations of all
> > 
> > Hello,
> > 
> > I see that you use the term "open for extension but closed for modification"
> > here and in order patches. Could you please clarify what this means? "closed
> > for modification" doesn't seem to make much sense for an open source 
> > project,
> > where all the code is always open for modification.
> > 
> > Thanks, Roger.
> 
> Thanks for your review! "closed for modification" means we do not need modify
> the most codes, especially the main flows, when we add a new feature into
> codes.

IMHO, just saying that the current code is easily to extend in order to add new
features sounds better.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel