[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 2/2] efi/boot: Don't free ebmalloc area at all
>>> On 28.02.17 at 20:09, <andrew.cooper3@xxxxxxxxxx> wrote: > On 28/02/17 19:01, Daniel Kiper wrote: >> Looking at this I do not have a better idea for fix off the top of my head. Well, one better solution was already suggested: Put it in .init.data and suppress the freeing of the used part of it. The other option is to put a section along the lines of Linux'es .brk _after_ .bss (whether ahead of or after _end would need to be seen), replacing the uses of __2M_rwdata_end by a runtime calculated value (and freeing space past the used portion accordingly, without shattering large pages if used). >> So, I have a feeling that we should drop free_ebmalloc_unused_mem() and leave >> comment around ebmalloc() why we do not reclaim unused ebmalloc_mem region. >> Should I post a patch or whether you would like to do it? > > The patch at the root of this thread is basically that. > > As a stopgap solution to unblock staging, I think I should drop the > adjustment of MB(1) to KB(32) and submit the patch. > > This satisfies Jan's request to not make the current buffer smaller than > it currently is, and will give us more time to discuss alternative > solutions, at the cost of wasting 1MB of RAM. (Not exactly breaking the > bank these days, but definitely something which should be fixed before > 4.9 ships.) Yes, as an immediate band aid I can live with this. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |