Re: [Xen-devel] [PATCH v8 04/24] x86: refactor psr: implement CPU init and free flow.

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Wei Liu <wei.liu2@xxxxxxxxxx> 02/26/17 6:41 PM >>>
>On Wed, Feb 15, 2017 at 04:49:19PM +0800, Yi Sun wrote:
>> +static void free_feature(struct psr_socket_info *info)
>> +{
>> +    struct feat_node *feat, *next;
>> +
>> +    if ( !info )
>> +        return;
>> +
>> +    /*
>> +     * Free resources of features. But we do not free global feature list
>> +     * entry, like feat_l3_cat. Although it may cause a few memory leak,
>> +     * it is OK simplify things.
>
>I don't think it is OK to leak memory in the hypervisor in general.
>Please specify why it is OK in this particular case in the comment.

The problem is to call this a leak in the comment. There's no leak here,
the allocation is simply being kept until the next CPU online attempt.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel