Re: [Xen-devel] [PATCH v8 06/24] x86: refactor psr: implement get hw info flow.

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Feb 15, 2017 at 04:49:21PM +0800, Yi Sun wrote:
[...]
>  /* L3 CAT functions implementation. */
>  static void l3_cat_init_feature(struct cpuid_leaf regs,
>                                  struct feat_node *feat,
> @@ -225,8 +247,22 @@ static unsigned int l3_cat_get_cos_max(const struct 
> feat_node *feat)
>      return feat->info.l3_cat_info.cos_max;
>  }
>  
> +static bool l3_cat_get_feat_info(const struct feat_node *feat,
> +                                 uint32_t data[], unsigned int array_len)
> +{
> +    if ( !data || 3 > array_len )

I don't think this is documented, but this is the first time I see the
constant on the left. Maybe considering swapping it to array_len < 3?

Other than this:

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel