Re: [Xen-devel] [PATCH v2] iommu: Elaborate the usage of RMRR specification on the command line

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Feb 23, 2017 at 11:03:55AM -0600, Venu Busireddy wrote:
> As some users have suggested, elaborate the usage of RMRR specification
> on the command line, and provide a usage example.
> 
> Also, always treat the specified page numbers as hexadecimal values.
> 
> Signed-off-by: Venu Busireddy <venu.busireddy@xxxxxxxxxx>

Thanks! Just a minor comment, apart from that:

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

> ---
> 
>  Changes in v2:
>    - Provide a better usage example.
>    - Treat input page numbers as hexadecimal values.
> 
>  docs/misc/xen-command-line.markdown | 10 ++++++++++
>  xen/drivers/passthrough/vtd/dmar.c  |  4 ++--
>  2 files changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/misc/xen-command-line.markdown 
> b/docs/misc/xen-command-line.markdown
> index 3acbb33..a035c3f 100644
> --- a/docs/misc/xen-command-line.markdown
> +++ b/docs/misc/xen-command-line.markdown
> @@ -1406,6 +1406,16 @@ If segment of the first device is not specified, 
> segment zero will be used.
>  If other segments are not specified, first device segment will be used.
>  If a segment is specified for other than the first device and it does not 
> match
>  the one specified for the first one, an error will be reported.
> +
> +'start' and 'end' values are page numbers (not full physical addresses),
> +in hexadecimal format (can optionally be preceded by "0x").
> +
> +Usage example: If device 0:0:1d.0 requires one page (0xd5d45) to be
> +reserved, and device 0:0:1a.0 requires three pages (0xd5d46 thru 0xd5d48)
> +to be reserved, one usage would be:
> +
> +rmrr=d5d45=0:0:1d.0;0xd5d46-0xd5d48=0:0:1a.0

An example with multiple devices would also be nice, maybe something like:

rmrr=d5d45=0:0:1d.0,0:0:1f.0;0xd5d46-0xd5d48=0:0:1a.0

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel