Re: [Xen-devel] [PATCH v3 2/7] xenstore: rename XS_DEBUG wire command

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Feb 22, 2017 at 04:28:46PM +0100, Juergen Gross wrote:
> In preparation to support other than pure debug functionality via the
> Xenstore XS_DEBUG wire command rename it to XS_CONTROL and make
> XS_DEBUG an alias of it.
> 
> Add an alias xs_control_command for the associated xs_debug_command,
> too.
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> ---
>  tools/xenstore/include/xenstore.h |  4 +++-
>  tools/xenstore/xenstored_core.c   |  8 ++++----
>  tools/xenstore/xs.c               | 13 +++++++++----
>  xen/include/public/io/xs_wire.h   |  3 ++-
>  4 files changed, 18 insertions(+), 10 deletions(-)
> 
> diff --git a/tools/xenstore/include/xenstore.h 
> b/tools/xenstore/include/xenstore.h
> index 0d12c39..f460b8c 100644
> --- a/tools/xenstore/include/xenstore.h
> +++ b/tools/xenstore/include/xenstore.h
> @@ -262,7 +262,9 @@ bool xs_path_is_subpath(const char *parent, const char 
> *child);
>   */
>  bool xs_is_domain_introduced(struct xs_handle *h, unsigned int domid);
>  
> -/* Only useful for DEBUG versions */
> +char *xs_control_command(struct xs_handle *h, const char *cmd,
> +                      void *data, unsigned int len);
> +/* Deprecated: use xs_control_command() instead. */
>  char *xs_debug_command(struct xs_handle *h, const char *cmd,
>                      void *data, unsigned int len);

I would also suggest adding __attribute__((deprecated)) for the
declaration.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel