Re: [Xen-devel] [PATCH v2 1/5] xenstore: rename XS_DEBUG wire command

[Juergen Gross <jgross@xxxxxxxx>]

On 22/02/17 13:43, Wei Liu wrote:
> On Wed, Feb 22, 2017 at 01:40:42PM +0100, Juergen Gross wrote:
>> On 22/02/17 13:36, Wei Liu wrote:
>>> On Tue, Feb 21, 2017 at 04:07:33PM +0100, Juergen Gross wrote:
>>>> In preparation to support other than pure debug functionality via the
>>>> Xenstore XS_DEBUG wire command rename it to XS_CONTROL and make
>>>> XS_DEBUG an alias of it.
>>>>
>>>> Add an alias xs_control_command for the associated xs_debug_command,
>>>> too.
>>>>
>>>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>>>> ---
>>>>  tools/xenstore/include/xenstore.h | 2 +-
>>>>  tools/xenstore/xenstored_core.c   | 8 ++++----
>>>>  tools/xenstore/xs.c               | 7 +++----
>>>>  xen/include/public/io/xs_wire.h   | 3 ++-
>>>>  4 files changed, 10 insertions(+), 10 deletions(-)
>>>>
>>>> diff --git a/tools/xenstore/include/xenstore.h 
>>>> b/tools/xenstore/include/xenstore.h
>>>> index 0d12c39..66bb9ed 100644
>>>> --- a/tools/xenstore/include/xenstore.h
>>>> +++ b/tools/xenstore/include/xenstore.h
>>>> @@ -262,9 +262,9 @@ bool xs_path_is_subpath(const char *parent, const char 
>>>> *child);
>>>>   */
>>>>  bool xs_is_domain_introduced(struct xs_handle *h, unsigned int domid);
>>>>  
>>>> -/* Only useful for DEBUG versions */
>>>>  char *xs_debug_command(struct xs_handle *h, const char *cmd,
>>>>                   void *data, unsigned int len);
>>>> +#define xs_control_command xs_debug_command
>>>>  
>>>
>>> Should be the other way around?
>>>
>>
>> I did it that way to keep the xs_debug_command symbol in the library.
>> Otherwise someone using that function would have to rebuild.
>>
> 
> But then there is no xs_control_command symbol now.
> 
> I would just have two functions. xs_debug_command should be implemented
> with xs_control_command (plus some extra check to only allow certain
> behaviours if you fancy that).

Okay, if you like that better.


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel