Re: [Xen-devel] [PATCH v2] x86/VMX: sanitize VM86 TSS handling

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 17/02/17 12:03, Jan Beulich wrote:
> @@ -4267,6 +4336,12 @@ static int hvmop_get_param(
>      case HVM_PARAM_ACPI_S_STATE:
>          a.value = d->arch.hvm_domain.is_s3_suspended ? 3 : 0;
>          break;
> +
> +    case HVM_PARAM_VM86_TSS:
> +        a.value = (uint32_t)d->arch.hvm_domain.params
> +                                [HVM_PARAM_VM86_TSS_SIZED];
> +        break;

HVM_PARAM_VM86_TSS_SIZED needs to have VM86_TSS_UPDATED masked out on a
read, or the guest and toolstack will observe a crazy size if they read
the param back before CR0.PE is cleared.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

> +
>      case HVM_PARAM_X87_FIP_WIDTH:
>          a.value = d->arch.x87_fip_width;
>          break;


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel