Re: [Xen-devel] [PATCH 19/19] tools/xen-mceinj: support injecting LMCE

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Feb 21, 2017 at 07:50:38AM +0800, Haozhong Zhang wrote:
> On 02/20/17 12:53 +0000, Wei Liu wrote:
> > >  }
> > >  
> > > +static int inject_lmce(xc_interface *xc_handle, uint32_t cpu_nr)
> > > +{
> > > +    struct xen_mc mc;
> > > +    uint8_t *cpumap = NULL;
> > > +    size_t cpumap_size, line, shift;
> > > +    uint32_t nr_cpus;
> > > +    int ret;
> > > +
> > > +    nr_cpus = mca_cpuinfo(xc_handle);
> > > +    if ( !nr_cpus )
> > > +        err(xc_handle, "Failed to get mca_cpuinfo");
> > 
> > Why xc_handle in err()?
> >
> 
> err() needs to close xc_handle.
> 

Gosh, this is err in xen-mceinj.c, not err(3).

Sorry for the noise.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel