Re: [Xen-devel] [PATCH V3 5/7] COLO-Proxy: Add primary userspace colo proxy start args

[Zhang Chen <zhangchen.fnst@xxxxxxxxxxxxxx>]

On 02/20/2017 11:59 PM, Wei Liu wrote:
> On Fri, Feb 17, 2017 at 10:18:27AM +0800, Zhang Chen wrote:
> > Qemu need this args to start userspace colo-proxy.
> >
> > Signed-off-by: Zhang Chen <zhangchen.fnst@xxxxxxxxxxxxxx>
> [...]
> > +
> > +#undef APPEND_COLO_SOCK_SERVER
> > +#undef APPEND_COLO_SOCK_CLIENT
> I would move these a bit further up, right after the last site that uses
> them.
How about move it to here?

    } else {
        if (!sdl && !vnc) {
            flexarray_append(dm_args, "-nographic");
        }
    }

+#undef APPEND_COLO_SOCK_SERVER
+#undef APPEND_COLO_SOCK_CLIENT


    if (state->saved_state) {
        /* This file descriptor is meant to be used by QEMU */
        *dm_state_fd = open(state->saved_state, O_RDONLY);
        flexarray_append(dm_args, "-incoming");
        flexarray_append(dm_args, GCSPRINTF("fd:%d",*dm_state_fd));
    }


Thanks
Zhang Chen

> Wei.
>
>
> .
--
Thanks
Zhang Chen




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel