Re: [Xen-devel] [PATCH v3 1/2] fuzz/x86emul: avoid race in link farm rune

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.02.17 at 15:05, <wei.liu2@xxxxxxxxxx> wrote:
> On Mon, Feb 20, 2017 at 05:37:56AM -0700, Jan Beulich wrote:
>> >>> On 20.02.17 at 13:05, <wei.liu2@xxxxxxxxxx> wrote:
>> > +asm:
>> > +  [ -L $@ ] || ln -sf $(XEN_ROOT)/xen/include/asm-x86 $@
>> > +
>> > +asm/%: asm ;
>> 
>> Is the semicolon needed here? You don't have one above ...
>> 
> 
> Yes, this is needed; otherwise make complains not knowing how to make
> the target.  When I change x86_emulate.[ch] to use patter rule, I will
> need to add a semicolon as well.
> 
> From Make manual for empty recipes:
> 
> Empty recipes can also be used to avoid errors for targets that will be
> created as a side-effect of another recipe: if the target does not exist
> the empty recipe ensures that make won’t complain that it doesn't know
> how to build the target, and make will assume the target is out of date.

Oh, yes, of course.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel