Re: [Xen-devel] [PATCH 1/3] fuzz/x86emul: avoid race in link farm rune

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.02.17 at 11:12, <wei.liu2@xxxxxxxxxx> wrote:
> On Thu, Feb 16, 2017 at 07:10:41PM +0000, Andrew Cooper wrote:
>> On 16/02/17 18:56, Wei Liu wrote:
>> > --- a/tools/fuzz/x86_instruction_emulator/Makefile
>> > +++ b/tools/fuzz/x86_instruction_emulator/Makefile
>> > @@ -8,12 +8,16 @@ else
>> >  x86-instruction-emulator-fuzzer-all:
>> >  endif
>> >  
>> > -x86_emulate/x86_emulate.c x86_emulate/x86_emulate.h:
>> > +x86_emulate:
>> >    [ -L x86_emulate ] || ln -sf $(XEN_ROOT)/xen/arch/x86/x86_emulate .
>> >  
>> > -asm/x86-vendors.h asm/x86-defns.h asm/msr-index.h:
>> > +x86_emulate/x86_emulate.c x86_emulate/x86_emulate.h: x86_emulate
>> 
>> You should be able to do this:
>> 
>> x86_emulate/%: x86_emulate
>> 
> 
> Using % won't work. Jan made a similar comment during the first
> iteration of the fuzzer series. It turned out that we needed to list
> explicitly every file because of the other rules explicitly listed
> those files.

There was something in that area, but explicitly mentioning files
elsewhere should not prevent this dependency to work as long as
the files don't exist without the rule's commands having run.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel