Re: [Xen-devel] [PATCH 02/28] ARM: GICv3 ITS: parse and store ITS subnodes from hardware DT

[Julien Grall <julien.grall@xxxxxxx>]

On 16/02/17 17:44, Andre Przywara wrote:
> Hi Julien,
Hi Andre,

> On 06/02/17 12:39, Julien Grall wrote:
> > On 30/01/17 18:31, Andre Przywara wrote:
> > > +
> > > +        if ( !dt_device_is_compatible(its, "arm,gic-v3-its") )
> > > +            continue;
> > > +
> > > +        if ( !dt_device_is_available(its) )
> > > +            continue;
> > Can an ITS really be disabled? Or is it just for debugging?
> This was indeed introduced for debugging, but is useful with multiple
> ITSes. Firmware could ship with a DT covering the maximum hardware
> configuration, then disabling not existing hardware at boot time.
>
> And in general I consider this good style to support the status property.
I tend to agree here, however this will have a side-effect on the 
device-tree generated for DOM0. The ITS node will not be replicated and 
you will end up using a broken device-tree. While Linux will only 
complain, some other OS may just abort.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel