[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC 1/6] rangeset_new() refactoring

To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
From: Andrii Anisov <andrii.anisov@xxxxxxxxx>
Date: Thu, 16 Feb 2017 15:15:01 +0200
Cc: Wei Liu <wei.liu2@xxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "andrii_anisov@xxxxxxxx" <andrii_anisov@xxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, "Tim \(Xen.org\)" <tim@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 16 Feb 2017 13:15:19 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>

>> +    if ( d != NULL )
>
> Shouldn't d == NULL be a hard error now, in which you could pass d->rangesets 
> directly into rangeset_new() (under lock).

It definitely should. Because this is a domain specific code.

Sincerely,
Andrii Anisov.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

References:
- [Xen-devel] [RFC 0/6] Rangeset generalisation
  - From: Andrii Anisov
- [Xen-devel] [RFC 1/6] rangeset_new() refactoring
  - From: Andrii Anisov
- Re: [Xen-devel] [RFC 1/6] rangeset_new() refactoring
  - From: Paul Durrant

Prev by Date: Re: [Xen-devel] [RFC 0/6] Rangeset generalisation
Next by Date: [Xen-devel] [xen-4.6-testing test] 105831: tolerable FAIL - PUSHED
Previous by thread: Re: [Xen-devel] [RFC 1/6] rangeset_new() refactoring
Next by thread: [Xen-devel] [RFC 3/6] Drop rangeset_domain_initialise()
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.