Re: [Xen-devel] [PATCH v15 05/10] x86: add multiboot2 protocol support for EFI platforms

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.02.17 at 19:38, <daniel.kiper@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/boot/head.S
> +++ b/xen/arch/x86/boot/head.S
> @@ -394,10 +394,18 @@ __start:
> 
>          /* EFI IA-32 platforms are not supported. */
>          cmpl    $MULTIBOOT2_TAG_TYPE_EFI32,MB2_tag_type(%ecx)
> +        /*
> +         * Here we should zap vga_text_buffer. However, we can disable
> +         * VGA updates in simpler and more reliable way later.
> +         */
>          je      .Lmb2_efi_ia_32
> 
>          /* Bootloader shutdown EFI x64 boot services. */
>          cmpl    $MULTIBOOT2_TAG_TYPE_EFI64,MB2_tag_type(%ecx)
> +        /*
> +         * Here we should zap vga_text_buffer. However, we can disable
> +         * VGA updates in simpler and more reliable way later.
> +         */
>          je      .Lmb2_no_bs

I'm afraid I don't view these comments as helpful in understanding
the whole situation. That's partly because I don't follow both the
"simpler" and "more reliable" parts (using just the information here,
i.e. leaving aside what you've given as explanation earlier, albeit I
don't think that was fully clarifying things either), and partly
because I continue to think that the explanation should go where
the labels are (which is what I had meant to suggest with my
comment placement in reply to v14). Nor does the adjustment
above help (me) understand the correctness of the dual use of
.Lmb2_no_bs.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel