Re: [Xen-devel] [PATCH v4 4/4] build: enable no-parentheses in clang

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 14/02/17 12:30, Roger Pau Monne wrote:
> And fix the following errors reported:
>
> traps.c:2014:25: error: equality comparison with extraneous parentheses
>       [-Werror,-Wparentheses-equality]
>         else if ( (port == RTC_PORT(0)) )
>                    ~~~~~^~~~~~~~~~~~~~
> traps.c:2014:25: note: remove extraneous parentheses around the comparison to 
> silence this warning
>         else if ( (port == RTC_PORT(0)) )
>                   ~     ^             ~
> traps.c:2014:25: note: use '=' to turn this equality comparison into an 
> assignment
>         else if ( (port == RTC_PORT(0)) )
>                         ^~
>                         =
> traps.c:2083:25: error: equality comparison with extraneous parentheses
>       [-Werror,-Wparentheses-equality]
>         else if ( (port == RTC_PORT(0)) )
>                    ~~~~~^~~~~~~~~~~~~~
>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Cc: Tim Deegan <tim@xxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel