[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 04/28] ARM: GICv3 ITS: allocate device and collection table
On Mon, 6 Feb 2017, Julien Grall wrote: > > +static uint64_t encode_phys_addr(paddr_t addr, int page_bits) > > +{ > > + uint64_t ret; > > + > > + if ( page_bits < 16 ) > > + return (uint64_t)addr & GENMASK(47, page_bits); > > + > > + ret = addr & GENMASK(47, 16); > > + return ret | (addr & GENMASK(51, 48)) >> (48 - 12); > > +} > > + > > +#define PAGE_BITS(sz) ((sz) * 2 + PAGE_SHIFT) > > I know that PAGE_SHIFT has been suggested by Stefano on the previous version. > However, I think this is wrong. The PAGE_BITS is not based on the page > granularity of Xen, so I would much prefer to keep an 12 hardcoded with a > comment. OK _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |