Re: [Xen-devel] [PATCH] configure: disable bash check for FreeBSD

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Feb 13, 2017 at 03:49:14PM +0000, Roger Pau Monne wrote:
> Sorry, I've forgot to re-generate the patch after adding the maintainers...
> 
> On Mon, Feb 13, 2017 at 03:47:38PM +0000, Roger Pau Monne wrote:
> > Bash it's not used on FreeBSD.
> > 
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > ---
> > Please re-run autoconf after applying
> > ---
> >  tools/configure.ac | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tools/configure.ac b/tools/configure.ac
> > index 873e18d..28a539c 100644
> > --- a/tools/configure.ac
> > +++ b/tools/configure.ac
> > @@ -320,7 +320,11 @@ AS_IF([test "x$xsmpolicy" = "xy"], [
> >          xsmpolicy="n"
> >      ])
> >  ])
> > -AX_PATH_PROG_OR_FAIL([BASH], [bash])
> > +dnl FreeBSD doesn't require bash (hotplug scripts are in plain sh)

I am not sure I follow this comment.  It implies hotplug scripts are the
only shell scripts that we ship or care and this check here is
specifically for that purpose.

If this comment is correct, isn't it better to just  remove this check?
AFAICT sh is standard.  If this comment is not correct, should we check
for the desired shell in FreeBSD?

Wei.

> > +case "$host_os" in
> > +  freebsd*) ;;
> > +  *) AX_PATH_PROG_OR_FAIL([BASH], [bash]);;
> > +esac
> >  AS_IF([echo "$PYTHON" | grep -q "^/"], [
> >      PYTHONPATH=$PYTHON
> >      PYTHON=`basename $PYTHONPATH`
> > -- 
> > 2.10.1 (Apple Git-78)
> > 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel