[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH RESEND v17] xen/sndif: Add sound-device ABI
On February 9, 2017 3:46:10 AM EST, Oleksandr Andrushchenko <andr2000@xxxxxxxxx> wrote: > > >On 02/08/2017 05:29 PM, Konrad Rzeszutek Wilk wrote: >> . snip.. >>>> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> >>> >Couple of issues I found in sndif while preparing displif for review: >1. missing string constants >+#define XENSND_FIELD_BE_VERSIONS "versions" >+#define XENSND_FIELD_FE_VERSION "version" > >2. I would like to have one more part in the state diagrams section >which is currently missing: recovery flow for the case when >backend/frontend dies: > >+ *------------------------------- Recovery flow >------------------------------- >+ * >+ * In case of frontend unrecoverable errors backend handles that as >+ * if frontend goes into the XenbusStateClosed state. >+ * >+ * In case of backend unrecoverable errors frontend tries removing >+ * the emulated device. If this is possible at the moment of error, >+ * then frontend goes into the XenbusStateInitialising state and is >ready for >+ * new connection with backend. If the emulated device is still in use >and >+ * cannot be removed, then frontend goes into the >XenbusStateReconfiguring state >+ * until either the emulated device removed or backend initiates a new >+ * connection. On the emulated device removal frontend goes into the >+ * XenbusStateInitialising state. >+ * > Thanks, feel free to include this and my reviewed by tag. >Thank you, >Oleksandr Thanks! _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |