[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v6 04/24] x86: refactor psr: implement CPU init and free flow.
On 17-02-08 11:34:16, Konrad Rzeszutek Wilk wrote: > > + /* No valid value so do not enable feature. */ > > + if ( !regs.a || !regs.b ) > > You use regs.d below. Would it make sense to check for that value as > well? > > Or is a value of 0 for cox_max OK? I would think so, but not exactly > sure. > Sorry, this is a typo. > > + { > > + free_feature(socket_info + socket); > > + } > > +} > > + > > +static void __init init_psr(void) > > Why don't we make this return an value? And then the init > code(psr_presmp_init) can just return an error? Because we need init CMT related things besides CAT in psr_presmp_init. So no matter init_psr return value, we need call psr_cpu_init to call psr_assoc_init. We will check if socket_info in following functions called to avoid error. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |