[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v3 3/4] x86/vvmx: correctly emulate VMWRITE
>>> On 08.02.17 at 11:09, <sergey.dyasli@xxxxxxxxxx> wrote: > --- a/xen/arch/x86/hvm/vmx/vvmx.c > +++ b/xen/arch/x86/hvm/vmx/vvmx.c > @@ -305,6 +305,19 @@ void set_vvmcs_real(const struct vcpu *v, u32 encoding, > u64 val) > virtual_vmcs_vmwrite(v, encoding, val); > } > > +enum vmx_insn_errno set_vvmcs_virtual_safe(void *vvmcs, u32 encoding, u64 > val) > +{ > + set_vvmcs_virtual(vvmcs, encoding, val); > + > + return 0; I think the growing number of literal zeros requires the introduction of a "no error" enumerator value, probably even to be used by the two earlier patches (which, if you did so, wouldn't invalidate my R-b). Furthermore, didn't earlier discussion result in it being desirable to at least add a comment here clarifying that the unconditional returning of success isn't really the intended behavior (i.e. more work is needed here)? Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |