Re: [Xen-devel] [PATCH 2/2] xl: disable events earlier for shutdown event

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("Re: [PATCH 2/2] xl: disable events earlier for shutdown 
event"):
> No, handling NULL is not enough. It could well be possible that diskws
> is not NULL but then num_disks grows, thus making evdisable_disk_ejects
> access out of bound.

The additional diskws entries could be zeroed then.  But, ...

> The other solution is to have a dedicated counter for diskws instead of
> relying on num_disks.

... this is a good approach too.

> Subject: [PATCH] xl: track size of diskws with a dedicated counter
> 
> The num_disks field can change during guest lifetime. Don't use that as
> the size of diskws, use a dedicated counter instead.
> 
> Also free diskws and reset diskws to NULL after disabling events so that
> it will be automatically re-created when the guest reboots.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel