Re: [Xen-devel] [PATCH 2/4] x86/vmx: improve __vmread_safe()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 31.01.17 at 12:20, <sergey.dyasli@xxxxxxxxxx> wrote:
> --- a/xen/include/asm-x86/hvm/vmx/vmx.h
> +++ b/xen/include/asm-x86/hvm/vmx/vmx.h
> @@ -401,32 +401,27 @@ static always_inline void __vmwrite(unsigned long 
> field, unsigned long value)
>          );
>  }
>  
> -static inline bool_t __vmread_safe(unsigned long field, unsigned long *value)
> +static inline unsigned long __vmread_safe(unsigned long field,
> +                                          unsigned long *value)

Along the lines of the comments to patch 1, please take the
opportunity and drop the stray leading underscores. Other comments
made there apply here too.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel