[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v3 2/2] swiotlb-xen: implement xen_swiotlb_get_sgtable callback
On Wed, Feb 01, 2017 at 02:30:53PM +0000, Julien Grall wrote: > Hi Konrad, > > On 01/02/2017 14:25, Konrad Rzeszutek Wilk wrote: > > On Wed, Feb 01, 2017 at 12:46:32PM +0200, Andrii Anisov wrote: > > > Yup, > > > > > > Following is wrong: > > > > DEBUG macro could be globally across drivers defined by > > > > CONFIG_DEBUG_DRIVERS. See drivers/base/Makefile. > > > DEBUG is not defined globally. And there is no debug option to enable > > > DEBUG in drivers/xen/Makefile. > > > Should it be added? > > > > I am not exactly sure why you guys insist on having this, but > > the lets leave it as #if 0 along with a comment saying why and what > > the purpose of this is. > > From my understanding, the function has been implemented with the assumption > of the page will always belongs to the domain and not foreign. > > A user will unlikely know that it needs to remove #if 0 in order to check > the driver is doing the right thing. So I think we should have an easy way > to enable this code in kernel build. > > If you are not happy with the Kconfig, what would be the other way to have > this enabled without requiring the user to modify the code? Just leave the #if 0 in the code and add a comment explaining why it is there. > > Cheers, > > -- > Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |