Re: [Xen-devel] [PATCH] xen: credit2: non Credit2 pCPUs are ok during shutdown/suspend.

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On 28/01/17 01:42, Dario Faggioli wrote:
> Commit 7478ebe1602e6 ("xen: credit2: fix shutdown/suspend
> when playing with cpupools"), while doing the right thing
> for actual code, forgot to update the ASSERT()s accordingly,
> in csched2_vcpu_migrate().
> 
> In fact, as stated there already, during shutdown/suspend,
> we must allow a Credit2 vCPU to temporarily migrate to a
> non Credit2 BSP, without any ASSERT() triggering.
> 
> Move them down, after the check for whether or not we are
> shutting down, where the assumption that the pCPU must be
> valid Credit2 ones, is valid.
> 
> Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> ---
> Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> Cc: Anshul Makkar <anshul.makkar@xxxxxxxxxx>
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> If 7478ebe1602e is backported, this one should be as well.
> 
> Sorry for this. I'm sure I tested, so I don't know how it could happened... I
> must have forgotten debug=n when testing this case. :-(

Indeed, and sorry I missed this on review as well.

Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel