Re: [Xen-devel] [PATCH qemu-xen-traditional 1/2] xen_platform: unplug also SCSI disks [and 1 more messages]

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Olaf Hering writes ("Re: [Xen-devel] [PATCH qemu-xen-traditional 1/2] 
xen_platform: unplug also SCSI disks [and 1 more messages]"):
> So what should be done with the two patches?
> Are they acceptable for staging, or will they be rejected?

I am happy with the first patch, as I say.  Would you like me to apply
it while we discuss the 2nd ?

As for the 2nd patch: the last new feature was added to qemu-xen in
late 2011 ("qemu-xen: add vkbd support for PV on HVM guests"
9b33a3e5603e) or maybe early 2012 ("xen: introduce an event channel
for buffered io event notifications" a5af89a7d40d).

You are asking for a new feature to be accepted in a codebase which
has been on receiving only security fixes and bitrot fixes for many
years.

AFAICT it seems unlikely that this new feature will add new security
bugs, but might it break some old guests which mistakenly write to
this ioport ?

I think if you can reassure me about this point, I may be persuaded to
accept the patch.

Very sorry to be so awkward.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel