[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 04/12] x86emul/test: use x86-vendors.h



>>> On 31.01.17 at 12:08, <wei.liu2@xxxxxxxxxx> wrote:
> --- a/tools/tests/x86_emulator/x86_emulate.h
> +++ b/tools/tests/x86_emulator/x86_emulate.h
> @@ -6,6 +6,8 @@
>  #include <string.h>
>  #include <xen/xen.h>
>  
> +#include "../../../xen/include/asm-x86/x86-vendors.h"

I think we'd better avoid includes of this style. May I suggest
symlinking the needed headers, just like we already do with the
x86_emulate/x86_emulate[ch] files (perhaps to an include/
subdirectory in the build tree)?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.