Re: [Xen-devel] [PATCH 2/4] tools/fuzz: add AFL stub program for x86 insn emulator fuzzer

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.01.17 at 13:11, <wei.liu2@xxxxxxxxxx> wrote:
> @@ -33,7 +35,10 @@ distclean: clean
>  
>  .PHONY: clean
>  clean:
> -     rm -f *.a *.o
> +     rm -f *.a *.o afl-x86-insn-emulator-fuzzer

Perhaps *-x86-insn-emulator-fuzzer right away?

> --- /dev/null
> +++ b/tools/fuzz/x86_instruction_emulator/afl-x86-insn-emulator-fuzzer.c
> @@ -0,0 +1,42 @@
> +#include <assert.h>
> +#include <fcntl.h>
> +#include <stdint.h>
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <sys/stat.h>
> +#include <sys/types.h>
> +#include <unistd.h>
> +
> +extern int LLVMFuzzerTestOneInput(const uint8_t *data_p, size_t size);
> +
> +static uint8_t input[4096];
> +
> +int main(int argc, char **argv)
> +{
> +    size_t size;
> +    int fd;
> +
> +    if ( argc != 2 )
> +    {
> +        printf("Expecting only one argument\n");
> +        exit(1);
> +    }
> +
> +    fd = open(argv[1], O_RDONLY, 0);
> +    assert(fd != -1);
> +    size = read(fd, input, sizeof(input));
> +    close(fd);
> +
> +    LLVMFuzzerTestOneInput(input, size);

Please handle the case of read() failing (at least in the same way as
you do for open()). With that
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel