[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v7 06/14] firmware/Makefile: force recompilation if makefile changes



On Thu, Jan 19, 2017 at 12:19:15PM +0100, Greg KH wrote:
> On Sun, Jan 15, 2017 at 01:10:49PM -0800, Luis R. Rodriguez wrote:
> > If you modify the target asm we currently do not force the
> > recompilation of the firmware files. The target asm is in
> > the firmware/Makefile, peg this file as a dependency to
> > require re-compilation of firmware targets when the asm
> > changes.
> > 
> > v3: introduced in this series
> > 
> > Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxx>
> > ---
> >  firmware/Makefile | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/firmware/Makefile b/firmware/Makefile
> > index e297e1b52636..fa3e81c2a97b 100644
> > --- a/firmware/Makefile
> > +++ b/firmware/Makefile
> > @@ -176,7 +176,8 @@ quiet_cmd_fwbin = MK_FW   $@
> >  wordsize_deps := $(wildcard include/config/64bit.h include/config/32bit.h \
> >             include/config/ppc32.h include/config/ppc64.h \
> >             include/config/superh32.h include/config/superh64.h \
> > -           include/config/x86_32.h include/config/x86_64.h)
> > +           include/config/x86_32.h include/config/x86_64.h \
> > +           firmware/Makefile)
> >  
> >  $(patsubst %,$(obj)/%.gen.S, $(fw-shipped-y)): %: $(wordsize_deps)
> >     $(call cmd,fwbin,$(patsubst %.gen.S,%,$@))
> 
> I don't understand why this patch is in this series :(

I've taken it out and it has now been routed via kbuild folks as you
requested.

Thanks!

  Luis

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.