Re: [Xen-devel] [PATCH v5 5/9] x86/hvm: add vcpu parameter to guest memory copy function

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

On Fri, Jan 20, 2017 at 07:45:35PM +0000, Andrew Cooper wrote:
> On 19/01/17 17:29, Roger Pau Monne wrote:
> > @@ -3172,9 +3173,9 @@ static enum hvm_copy_result __hvm_copy(
> >              {
> >                  static unsigned long lastpage;
> >                  if ( xchg(&lastpage, gfn) != gfn )
> > -                    gdprintk(XENLOG_DEBUG, "guest attempted write to 
> > read-only"
> > +                    printk(XENLOG_DEBUG, "%pv guest attempted write to 
> > read-only"
> >                               " memory page. gfn=%#lx, mfn=%#lx\n",
> > -                             gfn, page_to_mfn(page));
> > +                             vcpu->domain, gfn, page_to_mfn(page));
> 
> Just vcpu here, or hitting this printk() will try to follow
> d->shared_info as if it were v->domain.
>
> With this fixed, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Thanks, not sure why I've used domain here instead of vcpu.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel