Re: [Xen-devel] [PATCH] x86/emul: Fix clang build following BMI1/BMI2/TBM instruction support

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.01.17 at 16:37, <andrew.cooper3@xxxxxxxxxx> wrote:
> Travis reports that Clang objects to integer truncation during assignments to
> a bitfield:
> 
>   ./x86_emulate/x86_emulate.c:6150:19: error: implicit truncation from 'int'
>   to bitfield changes value from -1 to 15 
> [-Werror,-Wbitfield-constant-conversion]
>           pxop->reg = ~0; /* rAX */
>                     ^ ~~
> 
> Use 0xf instead.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reluctantly
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
as I think the code was just fine before.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel