Re: [Xen-devel] [PATCH v5 2/9] x86/iommu: add IOMMU entries for p2m_mmio_direct pages

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

On Fri, Jan 20, 2017 at 06:41:06AM +0000, Tian, Kevin wrote:
> > From: Roger Pau Monne [mailto:roger.pau@xxxxxxxxxx]
> > Sent: Friday, January 20, 2017 1:30 AM
> > 
> > There's nothing wrong with allowing the domain to perform DMA transfers to
> > MMIO areas that it already can access from the CPU, and this allows us to
> > remove the hack in set_identity_p2m_entry for PVH Dom0.
> > 
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> [...]
> > @@ -840,6 +840,10 @@ static inline unsigned int 
> > p2m_get_iommu_flags(p2m_type_t
> > p2mt)
> >      case p2m_grant_map_ro:
> >          flags = IOMMUF_readable;
> >          break;
> > +    case p2m_mmio_direct:
> > +        flags = IOMMUF_readable;
> > +        if ( rangeset_contains_singleton(mmio_ro_ranges, mfn_x(mfn)) )
> > +            flags |= IOMMUF_writable;
> 
> I suppose you meant !rangeset_contains_singleton...

Yes, that's for catching that, it's now fixed.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel