Re: [Xen-devel] [PATCH] xenstore: remove XS_RESTRICT support

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 19/01/17 11:01, Wei Liu wrote:
> On Wed, Jan 18, 2017 at 07:15:44PM +0100, Juergen Gross wrote:
> [...]
>> diff --git a/xen/include/public/io/xs_wire.h 
>> b/xen/include/public/io/xs_wire.h
>> index 54c1d71..751bd17 100644
>> --- a/xen/include/public/io/xs_wire.h
>> +++ b/xen/include/public/io/xs_wire.h
>> @@ -48,7 +48,7 @@ enum xsd_sockmsg_type
>>      XS_IS_DOMAIN_INTRODUCED,
>>      XS_RESUME,
>>      XS_SET_TARGET,
>> -    XS_RESTRICT,
>> +    XS_PAD_1,           /* XS_RESTRICT has been removed */
> XS_RESERVED_0/1 is better.
>
> Other than this, the modification looks good.

How about?

XS_SET_TARGET,
/* XS_RESTRICT has been removed */
XS_RESET_WATCHES = XS_SET_TARGET + 2,

This doesn't involve adding an pad/reserved identifier.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel