Re: [Xen-devel] [PATCH] tools/libxl: modify static-max in xenstore when setting maxmem

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Jan 18, 2017 at 07:25:57PM +0100, Juergen Gross wrote:
> xl mem-max is setting the hypervisor memory limit of a domain, but not
> the memory/static-max value in Xenstore. This prohibits setting the
> memory size above the old maximum size.
> 
> Set the new maximum value in Xenstore.
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

This looks sensible. But memory accounting is a thorny area.

Could you try to do local migration test for both PV and HVM guests with
this patch applied (with or w/out changing maxmem)?

> ---
>  tools/libxl/libxl.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> index 0622311..f59ec42 100644
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -4077,6 +4077,9 @@ int libxl_domain_setmaxmem(libxl_ctx *ctx, uint32_t 
> domid, uint64_t max_memkb)
>          goto out;
>      }
>  
> +    libxl__xs_printf(gc, XBT_NULL, GCSPRINTF("%s/memory/static-max", 
> dompath),
> +                     "%"PRIu64, max_memkb);
> +
>      rc = 0;
>  out:
>      libxl_domain_config_dispose(&d_config);
> -- 
> 2.10.2
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel