Re: [Xen-devel] [PATCH v3 5/8] dm_op: convert HVMOP_modified_memory

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.01.17 at 15:58, <paul.durrant@xxxxxxxxxx> wrote:
> v3:
> - Addressed more comments from Jan.

I'd have hoped you would extend these earlier comments to other
applicable places, i.e. for this patch ...

> +static int modified_memory(struct domain *d, xen_pfn_t *first_pfn,
> +                           unsigned int *nr)
> +{
> +    xen_pfn_t last_pfn = *first_pfn + *nr - 1;
> +    unsigned int iter;
> +    int rc;
> +
> +    if ( (*first_pfn > last_pfn) ||
> +         (last_pfn > domain_get_maximum_gpfn(d)) )
> +        return -EINVAL;
> +
> +    if ( !paging_mode_log_dirty(d) )
> +        return 0;
> +
> +    iter = 0;
> +    rc = 0;

... here (these would again better be initializers of the respective
variables). But anyway, hypervisor parts
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel