Re: [Xen-devel] [PATCH 2/4] x86/cpuid: Store the toolstacks choice of hypervisor max leaf

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.01.17 at 18:44, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/domctl.c
> +++ b/xen/arch/x86/domctl.c
> @@ -136,6 +136,14 @@ static int update_domain_cpuid_info(struct domain *d,
>              p->basic.raw[ctl->input[0]] = leaf;
>          break;
>  
> +    case 0x40000000:
> +        p->hv_limit = ctl->eax;
> +        break;
> +
> +    case 0x40000100:
> +        p->hv2_limit = ctl->eax;
> +        break;

Generally the patch is fine, but do we really need to store two limits
here? Can't we rely on the Viridian flag to be set first, so we could
use it here? And if indeed we can't right now, should it not be made
so as a first step?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel