Re: [Xen-devel] [PATCH v4 4/6] x86emul: support VME and PVI

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 11/01/17 15:26, Jan Beulich wrote:
>>>> On 11.01.17 at 16:15, <andrew.cooper3@xxxxxxxxxx> wrote:
>> On 10/01/17 09:04, Jan Beulich wrote:
>>> @@ -1178,6 +1180,15 @@ _mode_iopl(
>>>      fail_if(_iopl < 0);                         \
>>>      _iopl;                                      \
>>>  })
>>> +#define mode_pvi() ({                                        \
>>> +    unsigned long cr4 = 0;                                   \
>>> +    if ( ops->read_cr && get_cpl(ctxt, ops) == 3 )           \
>>> +    {                                                        \
>>> +        rc = ops->read_cr(4, &cr4, ctxt);                    \
>>> +        if ( rc != X86EMUL_OKAY ) goto done;                 \
>>> +    }                                                        \
>>> +    !!(cr4 & (_regs._eflags & EFLG_VM ? CR4_VME : CR4_PVI)); \
>>> +})
>> The name mode_pvi() is misleading, because VME and PVI behave
>> differently for everything other than cli/sti.
>>
>> mode_vif() would be better IMO, as it describes a condition under which
>> VIF should be used instead of IF.
> I don't mind - if that's the only change you ask for, that's easy
> enough to do.

Well - you snipped the main part of the reply where (I clearly didn't
say obviously enough) that I think this change now regresses our
emulation of pushf.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel