[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v13 0/3] iommu: add rmrr Xen command line option



> From: Venu Busireddy
> Sent: Wednesday, January 11, 2017 6:58 AM
> 
> From: Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>
> 
> Add Xen command line option rmrr to specify RMRR regions that are not
> defined in ACPI thus causing IO Page Faults and prevent dom0 from booting
> if "iommu=dom0-strict" option is specified on the Xen command line.
> These additional regions will be added to the list of RMRR regions parsed
> from ACPI.
> 
> Changes in v13:
>  - Implement feedback from Kevin Tian.
>    https://lists.xenproject.org/archives/html/xen-devel/2015-10/msg03169.html
>    https://lists.xenproject.org/archives/html/xen-devel/2015-10/msg03170.html
>    https://lists.xenproject.org/archives/html/xen-devel/2015-10/msg03171.html

Looks I gave my ack/review to all three patches. But you didn't put my acked-by
in patch [3/3]. Is there substantial change against v12 which requires my 
further
review?

>  - Limit all source lines and comments to 80 characters per line.
>  - Implement coding style suggestions from Konrad Wilk.
>  - Changed the Author to Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>
> 
> Changes in v12:
>  - Mostly cosmetic fixes from Jan's review on v11.
> 
> Changes in v11:
>  - changed macro to print extra RMRR ranges and added argument macro;
>  - fixed the overlapping check if condition error;
>  - fixed the loop exit condition when checking pfn in RMRR region;
> 
> Elena Ufimtseva (3):
>   iommu VT-d: separate rmrr addition function.
>   pci: add wrapper for parse_pci.
>   iommu: add rmrr Xen command line option for extra rmrrs
> 
>  docs/misc/xen-command-line.markdown |  13 ++
>  xen/drivers/passthrough/vtd/dmar.c  | 324
> +++++++++++++++++++++++++++++-------
>  xen/drivers/pci/pci.c               |  11 ++
>  xen/include/xen/pci.h               |   3 +
>  4 files changed, 292 insertions(+), 59 deletions(-)
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> https://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.