Re: [Xen-devel] [PATCH v2 02/10] x86/vLAPIC: Declare vlapic_read_aligned() and vlapic_reg_write() as non-static

[Suravee Suthikulpanit <Suravee.Suthikulpanit@xxxxxxx>]

On 01/05/2017 10:53 PM, Jan Beulich wrote:
> > > > On 31.12.16 at 06:45, <suravee.suthikulpanit@xxxxxxx> wrote:
> > Expose vlapic_read_aligned and vlapic_reg_write() to be used by AVIC.
> >
> > Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> > Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Generally I dislike functions being non-static when all their callers
> live in the same file. Therefore it would be better (and hardly
> harder to review) if they got made non-static at the point of their
> first external use. That'll also help understanding whether that's
> an appropriate move.
>
> Jan
IIUC, you want these changes to be in the same patch of the one making 
use of them externally. I can certainly combine this patch with patch 6/10.
Thanks,
S

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel