[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v5 04/14] tables.h: add linker table support
- To: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
- From: "Luis R. Rodriguez" <mcgrof@xxxxxxxxxx>
- Date: Mon, 9 Jan 2017 15:22:08 +0100
- Cc: One Thousand Gnomes <gnomes@xxxxxxxxxxxxxxxxxxx>, dalias@xxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, Jiri Kosina <jkosina@xxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, ming.lei@xxxxxxxxxxxxx, Heiko Carstens <heiko.carstens@xxxxxxxxxx>, Platform Driver <platform-driver-x86@xxxxxxxxxxxxxxx>, James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, sparclinux@xxxxxxxxxxxxxxx, wangnan0@xxxxxxxxxx, Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx>, Linux-Arch <linux-arch@xxxxxxxxxxxxxxx>, markus.heiser@xxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, Russell King <linux@xxxxxxxxxxxxxxxx>, Linux-SH <linux-sh@xxxxxxxxxxxxxxx>, Will Deacon <will.deacon@xxxxxxx>, korea.drzix@xxxxxxxxx, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>, anil.s.keshavamurthy@xxxxxxxxx, fontana@xxxxxxxxxxxxxxx, Ingo Molnar <mingo@xxxxxxxxxx>, dsahern@xxxxxxxxx, linux-arm Mailing List <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, "dvhart@xxxxxxxxxxxxx" <dvhart@xxxxxxxxxxxxx>, David Woodhouse <dwmw2@xxxxxxxxxxxxx>, Guenter Roeck <linux@xxxxxxxxxxxx>, david.vrabel@xxxxxxxxxx, linux-xtensa@xxxxxxxxxxxxxxxx, Pali Rohár <pali.rohar@xxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, realmz6@xxxxxxxxx, Jani Nikula <jani.nikula@xxxxxxxxx>, Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>, Rusty Russell <rusty@xxxxxxxxxxxxxxx>, npiggin@xxxxxxxxx, acme@xxxxxxxxxx, jbaron@xxxxxxxxxx, ananth@xxxxxxxxxxxxxxxxxx, Borislav Petkov <bp@xxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, jpoimboe@xxxxxxxxxx, namhyung@xxxxxxxxxx, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, mcb30@xxxxxxxx, linux-kbuild@xxxxxxxxxxxxxxx, Alan Cox <alan@xxxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, chris@xxxxxxxxxx, Paul Bolle <pebolle@xxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, jcmvbkbc@xxxxxxxxx, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>, Adrian Hunter <adrian.hunter@xxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxxxxxx>, ak@xxxxxxxxxxxxxxx, "Luis R. Rodriguez" <mcgrof@xxxxxxxxxx>, mmarek@xxxxxxxx, msalter@xxxxxxxxxx, mhiramat@xxxxxxxxxx, jolsa@xxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>
- Delivery-date: Mon, 09 Jan 2017 14:22:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On Fri, Jan 06, 2017 at 10:43:59PM +0200, Andy Shevchenko wrote:
> On Fri, Jan 6, 2017 at 10:00 PM, Luis R. Rodriguez <mcgrof@xxxxxxxxxx> wrote:
> > On Wed, Jan 04, 2017 at 11:47:14AM +0200, Andy Shevchenko wrote:
> >> On Tue, Jan 3, 2017 at 11:25 PM, Luis R. Rodriguez <mcgrof@xxxxxxxxxx>
> >> wrote:
> >> > On Thu, Dec 22, 2016 at 03:58:18PM +0200, Andy Shevchenko wrote:
> >> >> On Wed, 2016-12-21 at 18:38 -0800, Luis R. Rodriguez wrote:
> >> >> > +#define LINKTABLE_FOR_EACH(pointer, tbl)
> >> >>
> >> >> Hmm... SOMEONE LIKES CAPITAL LETTERS FOR everything, right? :-)
> >> >>
> >> >> I would expect more standard linktable_for_each() macro
> >> >
> >> > hpa had recommended this, if he prefers a lower case I can change that
> >>
> >>
> >> > but I really do consider this bikeshedding.
> >>
> >> I don't think so:
> >> $ git grep -n FOR_EACH | wc -l
> >> 83
> >> $ git grep -n for_each | wc -l
> >> 23317
> >
> > OK, would you also prefer if LINKTABLE_RUN_ERR() and LINKTABLE_RUN_ALL()
> > were lowercase ? Or is that fine ? To be clear I'll leave upper case the
> > declarers and defines.
>
> My understanding that macros to run code -- lower case, definitions --
> upper case.
>
> Thus, *_run_*() macros to lower.
Very well, I've changed these, and since there were users I had to change
a bit of the other patches so will send a v6 series follow up.
Luis
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|
