Re: [Xen-devel] [PATCH 21/27] x86/cpuid: Calculate appropriate max_leaf values for the global policies

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 05/01/17 13:43, Jan Beulich wrote:
>>>> On 04.01.17 at 13:39, <andrew.cooper3@xxxxxxxxxx> wrote:
>> --- a/xen/include/asm-x86/cpuid.h
>> +++ b/xen/include/asm-x86/cpuid.h
>> @@ -78,10 +78,10 @@ struct cpuid_policy
>>       * Global *_policy objects:
>>       *
>>       * - Host accurate:
>> -     *   - max_{,sub}leaf
>>       *   - {xcr0,xss}_{high,low}
>>       *
>>       * - Guest appropriate:
>> +     *   - max_{,sub}leaf
>>       *   - All FEATURESET_* words
> I can see the point of the addition, but why the removal?

Because the max_{,sub}leaf fields are no longer host-accurate.  They are
min(host, tolerated policy).

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel