Re: [Xen-devel] [PATCH 25/27] x86/svm: Use guest_cpuid() rather than hvm_cpuid()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.01.17 at 13:39, <andrew.cooper3@xxxxxxxxxx> wrote:
> More work is required before LWP details can be read straight out of the
> cpuid_policy block, but in the meantime hvm_cpuid() wants to disappear so
> update the code to use the newer interface.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
albeit ...

> --- a/xen/arch/x86/hvm/svm/svm.c
> +++ b/xen/arch/x86/hvm/svm/svm.c
> @@ -926,17 +926,17 @@ static inline void svm_lwp_load(struct vcpu *v)
>  /* Update LWP_CFG MSR (0xc0000105). Return -1 if error; otherwise returns 0. 
> */
>  static int svm_update_lwp_cfg(struct vcpu *v, uint64_t msr_content)
>  {
> -    unsigned int edx;
> +    struct cpuid_leaf res;
>      uint32_t msr_low;
>      static uint8_t lwp_intr_vector;
>  
>      if ( xsave_enabled(v) && cpu_has_lwp )
>      {
> -        hvm_cpuid(0x8000001c, NULL, NULL, NULL, &edx);
> +        guest_cpuid(v, 0x8000001c, 0, &res);
>          msr_low = (uint32_t)msr_content;
>          
>          /* generate #GP if guest tries to turn on unsupported features. */
> -        if ( msr_low & ~edx)
> +        if ( msr_low & ~res.d)
>              return -1;

... please consider moving res into the inner scope.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel