Re: [Xen-devel] [PATCH RFC 59/59] tools/xenlight: Create interface for xenlight info

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On 29/12/16 01:14, Ronald Rojas wrote:
> Create interface to interact with libxl_verions_info
> and libxl_physinfo. Also introduce proper error
> handling.
> 
> Signed-off-by: Ronald Rojas <ronladred@xxxxxxxxx>

Hey Ronald,

When you send a series to a public open-source project, you want it to
be a sort of idealized set of changes that make it easy to "see the
forest for the trees", as it were, not the actual local development
path.  We don't need the full development history of libxl.go -- a
simple dump will be fine; and we definitely don't need all the other
stuff from schedbench in the xen.git history. :-)

All you needed to do to "import" my existing libxl code from schedbench was:

$ cd xen.git
$ cp ../schedbench.git/controller/libxl.go tools/golang/xenlight/xenlight.go
$ git add tools/golang/xenlight/xenlight.go

:-)

Also, in this patch it looks from the description like you are
incrementally adding a bit of new functionality: but since you also at
the same time rename the file from "libxl.go" to "xenlight.go", it's
difficult to tell what's going on.  In the future, mechanical changes
(like renaming a file or code motion) should be kept separate from
patches that add or modify functionality, so that it's easy to see
what's going on.

Let me take a look at what you've got.

 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel