Re: [Xen-devel] [RFC PATCH 5/9] x86/HVM/SVM: Add AVIC initialization code

[Suravee Suthikulpanit <Suravee.Suthikulpanit@xxxxxxx>]

On 12/22/16 18:16, Jan Beulich wrote:
> > > > On 19.09.16 at 07:52, <suravee.suthikulpanit@xxxxxxx> wrote:
> > +int svm_avic_init_vcpu(struct vcpu *v)
> > +{
> > +    struct vlapic *vlapic = vcpu_vlapic(v);
> > +    struct arch_svm_struct *s = &v->arch.hvm_svm;
> > +
> > +    if ( svm_avic )
> > +        s->avic_bk_pg = vlapic->regs_page;
> Why this copying? Can't consuming code not use vlapic->regs_page?
Hm.. good point. I'll get rid of avic_bk_pg and just use the regs_page.

Thanks,
Suravee

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel